Update secrets interface to work for CEL export #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=ba91b12 |
matthchr
force-pushed
the
matthchr/export-refactor
branch
from
ba91b12 to
03928a7
Compare
matthchr
commented
Oct 25, 2024
| // implements this interface is successfully provisioned. This method is invoked once a resource has been | ||
| // successfully created in Azure, but before the Ready condition has been marked successful. | ||
| ExportKubernetesResources( | ||
| ExportKubernetesConfigMaps( |
There was a problem hiding this comment.
This function actually can still export any Kubernetes resource, we just have a special function for secrets.
I could keep this as KubernetesExporter rather than making it ConfigMap specific. Not sure if that's better?
matthchr
force-pushed
the
matthchr/export-refactor
branch
from
03928a7 to
953b5c1
Compare
theunrepentantgeek
approved these changes
Oct 29, 2024
* Interface is now ExportKubernetesSecrets. * Now accepts additionalSecrets. * Now returns KubernetesSecretExportResult including RawSecrets map[string]string, which can be passed to CEL. * Also a new ExportConfigMaps interface for ConfigMaps.
matthchr
force-pushed
the
matthchr/export-refactor
branch
from
658cdba to
3c811a2
Compare
|
/ok-to-test sha=3c811a2 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2555