Improve secret detection heuristics #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
reviewed
Sep 30, 2024
theunrepentantgeek
force-pushed
the
improve/secret-detection
branch
from
1a057c9 to
2972d9b
Compare
super-harsh
reviewed
Oct 24, 2024
| @@ -2554,6 +2598,9 @@ objectModelConfiguration: | |||
| Databricks: | |||
| ResourceId: | |||
| $armReference: true | |||
| DatabricksProperties: | |||
| DatabricksAccessToken: | |||
There was a problem hiding this comment.
Where are the associated code-generated changes for this?
I only see 2 files in this PR now?
There was a problem hiding this comment.
This isn't new - it's relocated from just below - we're supposed to have things in alphabetical order, so I moved it up into place. That's why there's no change to generated code.
v2/azure-arm.yaml
Outdated
| @@ -2587,6 +2634,9 @@ objectModelConfiguration: | |||
| DatabricksProperties: | |||
| DatabricksAccessToken: | |||
| $isSecret: true | |||
| VirtualMachineSshCredentials_STATUS: | |||
| PrivateKeyData: | |||
There was a problem hiding this comment.
This shouldn't be included in the STATUS?
matthchr
reviewed
Oct 29, 2024
| @@ -2554,6 +2598,9 @@ objectModelConfiguration: | |||
| Databricks: | |||
| ResourceId: | |||
| $armReference: true | |||
| DatabricksProperties: | |||
| DatabricksAccessToken: | |||
There was a problem hiding this comment.
Where are the associated code-generated changes for this?
I only see 2 files in this PR now?
matthchr
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We've noticed a significant number of properties that should have been flagged as secrets, but which weren't noticed earlier. In this PR, we're improving our secret detection heuristics to try and prevent this from happening in the future.
Closes #4269
Special notes for your reviewer:
This detected a number of issues, which I think I've resolved correctly, but this needs a careful check.
Blocked on merge of #4237 and this will likely require a rebase after that one merges.
How does this PR make you feel:
