feat(helm): allow to use existing service account #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t3mi <[email protected]>
t3mi
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
approved these changes
Aug 28, 2024
|
/ok-to-test sha=23ab0f3 |
2 similar comments
|
/ok-to-test sha=23ab0f3 |
|
/ok-to-test sha=23ab0f3 |
|
I can't tell if the test that's failing is just flaky today for some reason or if there's something else going on. As far as I can tell there's nothing in this PR that would've changed this test though, and it's passing locally for me... |
|
Oh wait I am silly I retried it the wrong way... trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows to use existing service account and/or control the name of the created service account so that prerequisites (like federated identity setup) could be successfully passed during deployment without hardcoding service account name used in the chart.
How does this PR make you feel:
If applicable: