Fix bug where owner.armId could be changed #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=093e853 |
matthchr
force-pushed
the
feature/prevent-changing-armid
branch
from
093e853 to
7fcfce2
Compare
|
/ok-to-test sha=7fcfce2 |
theunrepentantgeek
approved these changes
Aug 18, 2024
super-harsh
approved these changes
Aug 18, 2024
It was never intended to allow changes to owner.armId, this protection was missed when adding owner.armId support. Even though this is technically a breaking change in the strictest sense, it's unlikely to break users as updating ARM ID, while not explicitly rejected, didn't actually work upstream in Azure for most cases. Fixes Azure#4181
matthchr
force-pushed
the
feature/prevent-changing-armid
branch
from
7fcfce2 to
534f383
Compare
|
/ok-to-test sha=534f383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never intended to allow changes to owner.armId, this protection was missed when adding owner.armId support.
Even though this is technically a breaking change in the strictest sense, it's unlikely to break users as updating ARM ID, while not explicitly rejected, didn't actually work upstream in Azure for most cases.
Fixes #4181
If applicable: