Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InterfaceImplementer ordering if interfaces have same name #4188

Merged

Conversation

matthchr
Copy link
Member

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr
Copy link
Member Author

/ok-to-test sha=d751396

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious where this came up!

@matthchr
Copy link
Member Author

matthchr commented Aug 12, 2024

In the work I'm doing locally for #2555, I've got two interfaces with the same name but ones from the secrets pkg and ones from the configmaps pkg.

When this happens, ordering becomes inconsistent (based on order in the underlying map)

@theunrepentantgeek
Copy link
Member

theunrepentantgeek commented Aug 12, 2024 via email

@matthchr matthchr added this pull request to the merge queue Aug 12, 2024
Merged via the queue into Azure:main with commit f39b85e Aug 12, 2024
7 checks passed
@matthchr matthchr deleted the feature/interface-implementer-ordering branch August 12, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants