Fix bug where 'none' crd-management mode blocked pod start #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
This happened because in 'none' mode goalCRDs was the set of installed CRDs, but we built an exclusion list from that set and used it to filter the set of known storage types from the scheme. When count(existing) = 5 and count(scheme)=200, the most you can possibly filter from the scheme with an exclusion list is 5 which leaves 195 CRDs being mistakenly installed. Fixes Azure#4146.
matthchr
force-pushed
the
feature/fix-crd-management-mode-none
branch
from
3378e10 to
a483c7f
Compare
theunrepentantgeek
approved these changes
Jul 7, 2024
|
/ok-to-test sha=a483c7f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because in 'none' mode goalCRDs was the set of installed CRDs, but we built an exclusion list from that set and used it to filter the set of known storage types from the scheme. When count(existing) = 5 and count(scheme)=200, the most you can possibly filter from the scheme with an exclusion list is 5 which leaves 195 CRDs being mistakenly installed.
Fixes #4146.
If applicable: