Add support to export eventhub keys #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
changed the title
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
matthchr
approved these changes
Mar 26, 2024
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to retreive response") | ||
| } | ||
|
|
|
|
||
| collector := secrets.NewCollector(obj.Namespace) | ||
|
|
||
| collector.AddValue(operatorSpecSecrets.PrimaryKey, *keys.PrimaryKey) |
There was a problem hiding this comment.
use to.Value rather than direct deref here to hedge against panics.
Suggested change
| collector.AddValue(operatorSpecSecrets.PrimaryKey, *keys.PrimaryKey) | |
| collector.AddValue(operatorSpecSecrets.PrimaryKey, to.Value(keys.PrimaryKey)) |
|
|
||
| collector := secrets.NewCollector(obj.Namespace) | ||
|
|
||
| collector.AddValue(operatorSpecSecrets.PrimaryKey, *keys.PrimaryKey) |
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to retreive response") | ||
| } | ||
|
|
|
|
||
| collector := secrets.NewCollector(obj.Namespace) | ||
|
|
||
| collector.AddValue(operatorSpecSecrets.PrimaryKey, *keys.PrimaryKey) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1542
What this PR does / why we need it:
Added ability to export Eventhub/Namespace and Authorization Rules Keys.
Bonus:
Add support for EventHub 2024-01-01 api versionNo bonuses for now :)Special notes for your reviewer:
Will add the test recordings once we hear back from EventHub team regarding 2024-01-01 version.If applicable: