-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signalr keys #3698
Signalr keys #3698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Had a few small comments.
v2/api/signalrservice/customizations/signal_r_extention_authorization.go
Outdated
Show resolved
Hide resolved
…ization.go Co-authored-by: Matthew Christopher <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
b666205
to
ffd9180
Compare
/ok-to-test sha=ffd9180 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
re-record signalr test
/ok-to-test sha=159b4eb |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3698 +/- ##
==========================================
+ Coverage 53.54% 53.57% +0.02%
==========================================
Files 1376 1411 +35
Lines 467398 483451 +16053
==========================================
+ Hits 250285 258989 +8704
- Misses 179480 185246 +5766
- Partials 37633 39216 +1583 ☔ View full report in Codecov by Sentry. |
Closes #3406
What this PR does / why we need it:
This PR adds SignalR API keys export
If applicable: