Add eventgrid/topic extension to export keys #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
theunrepentantgeek
approved these changes
Dec 6, 2023
Comment on lines
99
to
100
| collector.AddValue(operatorSpecSecrets.Key1, *keys.Key1) | ||
| collector.AddValue(operatorSpecSecrets.Key2, *keys.Key2) |
There was a problem hiding this comment.
Shouldn't these be guarded so you don't dereference if nill?
The guard condition on L#84 only says one of Key1 and Key2 are non-nil, it doesn't guarantee both are non-nill.
There was a problem hiding this comment.
I know the usual use case will be asking for both, but it's possible for a user to only ask for Key2 and that should work.
matthchr
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3630
What this PR does / why we need it:
Added eventgrid/topic extension to export keys.
Special notes for your reviewer:
Was trying on adding a latest stable version as well, but looks like their swagger has a field which is wrongly marked as secret.
If applicable: