Fix incorrect string case on namespace variable in Helm Chart #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewpeterson
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3440 +/- ##
=======================================
Coverage 54.39% 54.40%
=======================================
Files 1545 1545
Lines 649348 649348
=======================================
+ Hits 353206 353266 +60
+ Misses 238662 238612 -50
+ Partials 57480 57470 -10 |
super-harsh
approved these changes
Oct 19, 2023
|
/ok-to-test sha=179d79b |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ok-to-test sha=59a5c1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes improper case on NetworkPolicy namespace so the chart can generate the correct value for namespace
Special notes for your reviewer:
How does this PR make you feel:
Happy