-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for network/NatGateways #2906
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2906 +/- ##
=========================================
Coverage 54.34% 54.35%
=========================================
Files 1262 1270 +8
Lines 550814 552852 +2038
=========================================
+ Hits 299360 300499 +1139
- Misses 202453 203189 +736
- Partials 49001 49164 +163
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one concern about a deleted file.
Closes #2893
What this PR does / why we need it:
This PR adds support for
network/NatGateways
andnetwork/PublicIpPrefix
Note: Did try adding
network/CustomIpPrefix
as well, however, looks like their API has some issues, and its getting stuck inProvisioning
state too much in the background making it unable to delete. Resource in portal. link to docs stating about it getting stuck.If applicable: