Use real API Version enums #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
+ Coverage 53.12% 53.25% +0.12%
==========================================
Files 807 808 +1
Lines 238594 245438 +6844
==========================================
+ Hits 126757 130699 +3942
- Misses 93968 96242 +2274
- Partials 17869 18497 +628
Continue to review full report at Codecov.
|
theunrepentantgeek
approved these changes
May 17, 2022
Comment on lines
+42
to
+55
| // HACK: include the APIVersion in the storage types package. | ||
| // really we don't want storage types to have API Version at all, | ||
| // but it's difficult to remove the GetApiVersion() Function at the moment | ||
| storageAPIVersions := make(astmodel.TypeNameSet) | ||
| for _, tdef := range typesToConvert { | ||
| if rt, ok := astmodel.AsResourceType(tdef.Type()); ok && rt.HasAPIVersion() { | ||
| storageAPIVersions.Add(rt.APIVersionTypeName()) | ||
| } | ||
| } | ||
|
|
||
| for name := range storageAPIVersions { | ||
| typesToConvert.Add(state.Definitions()[name]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Could this be done by modifying (and renaming) the predicate isResourceOrObject instead?
There was a problem hiding this comment.
Not very easily, it would require another pass. I think it's good to call this out as the HACK that it is 😁
Ideally we wouldn't have these at all in the storage types, so this is a reminder that we would like to remove them in future.
matthchr
approved these changes
May 17, 2022
...nal/codegen/testdata/ArmResource/Arm_test_dependent_resource_and_ownership_crossplane.golden
Show resolved
Hide resolved
Co-authored-by: Matthew Christopher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1554