-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networking routetable and routes #1925
Conversation
be7ac2a
to
2b506bf
Compare
Codecov Report
@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 56.62% 56.58% -0.04%
==========================================
Files 375 381 +6
Lines 70285 71176 +891
==========================================
+ Hits 39799 40277 +478
- Misses 25591 25947 +356
- Partials 4895 4952 +57
Continue to review full report at Codecov.
|
96e94d7
to
34467a9
Compare
34467a9
to
13d126e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - presumably route table + routes don't have the same problem as vnets + subnets?
@babbageclunk - That's a good question. Will test before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off on this for now as it's subject to the same issues as VNET/Subnet. |
Closing as this can't merge without a fix to the networking embedded resources PUT behavior (on our side or theirs -- probably ours) |
If applicable: