Eliminate most use of hard coded strings for pipeline stage names #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
theunrepentantgeek
changed the title
theunrepentantgeek
changed the title
theunrepentantgeek
force-pushed
the
feature/convertible-resources
branch
from
7a5ba94 to
8890b7e
Compare
theunrepentantgeek
force-pushed
the
improve/code-gardening-202107
branch
from
3cbf7cf to
48fea67
Compare
5 tasks
theunrepentantgeek
force-pushed
the
feature/convertible-resources
branch
from
8890b7e to
994c3b5
Compare
theunrepentantgeek
force-pushed
the
improve/code-gardening-202107
branch
from
48fea67 to
b1c83a1
Compare
theunrepentantgeek
force-pushed
the
feature/convertible-resources
branch
from
994c3b5 to
55dd583
Compare
theunrepentantgeek
force-pushed
the
improve/code-gardening-202107
branch
from
b1c83a1 to
cbd24f7
Compare
theunrepentantgeek
force-pushed
the
feature/convertible-resources
branch
from
131ec1b to
3fb22f1
Compare
theunrepentantgeek
force-pushed
the
improve/code-gardening-202107
branch
from
cbd24f7 to
88c2074
Compare
matthchr
approved these changes
Jul 21, 2021
| pipeline.InjectOriginalVersionFunctionStageID, | ||
| pipeline.InjectOriginalVersionPropertyStageID, | ||
| pipeline.InjectPropertyAssignmentFunctionsStageID, | ||
| //pipeline.InjectHubFunctionStageID, |
There was a problem hiding this comment.
minor: Is this commented out for a reason? I think yes and it will be enabled later? Might be worth a TODO here
There was a problem hiding this comment.
I don't think we'll want to include this stage in tests, but we can't remove it until it's formally included in the pipeline. Comment added.
theunrepentantgeek
force-pushed
the
improve/code-gardening-202107
branch
from
88c2074 to
3aa75b8
Compare
matthchr
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Largely eliminates the use of magic strings to identify pipeline stages, which will help with future stability.
For a couple of stages where the prerequisites are intrinsic to correct behaviour, I moved the declaration of the prerequisite into the stage itself where it is less likely to be inadvertently removed.
Also includes a handful of other code gardening changes.
Prerequisites
masterHow does this PR make you feel:
