Convert Direction from enum into a discriminated union #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
- Coverage 64.92% 64.88% -0.04%
==========================================
Files 202 203 +1
Lines 12608 12603 -5
==========================================
- Hits 8186 8178 -8
- Misses 3709 3711 +2
- Partials 713 714 +1
Continue to review full report at Codecov.
|
4 tasks
theunrepentantgeek
force-pushed
the
improve/direction
branch
from
78128e7 to
0865bf6
Compare
theunrepentantgeek
force-pushed
the
feature/hub-function
branch
from
8959fb7 to
157c4eb
Compare
theunrepentantgeek
force-pushed
the
improve/direction
branch
from
0865bf6 to
dc9c56f
Compare
This was referenced Jul 7, 2021
babbageclunk
approved these changes
Jul 8, 2021
Comment on lines
+269
to
+270
| sourceType := fn.direction.SelectType(fn.otherDefinition.Type(), receiver.Type()) | ||
| destinationType := fn.direction.SelectType(receiver.Type(), fn.otherDefinition.Type()) |
There was a problem hiding this comment.
This bit is fiddly but I think still better than the original.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Code that needed to make a decision based on the direction of conversion always needed to handle "other" values with a panic; converting the type into an interface allows us to ensure that only valid implementations are provided, simplifying consumption.
This type will be used more frequently in upcoming PRs to implement type conversion.
Harvested from PR #1533
Prerequisites
masterSpecial notes for your reviewer:
Let us take a moment and lament how
SelectString()andSelectTypewould be a single method if Go had generics right now.How does this PR make you feel:
