Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test uses float value #1617

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Ensure test uses float value #1617

merged 1 commit into from
Jul 4, 2021

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Our CI builds have been failing because one of our lint tools has identified a problem in one of the tests for PropertyBag. This PR fixes the problem.

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

Codecov Report

Merging #1617 (4debf24) into master (0338b8d) will increase coverage by 0.72%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
+ Coverage   62.17%   62.89%   +0.72%     
==========================================
  Files         163      187      +24     
  Lines       10739    12355    +1616     
==========================================
+ Hits         6677     7771    +1094     
- Misses       3422     3899     +477     
- Partials      640      685      +45     
Impacted Files Coverage Δ
hack/generated/controllers/generic_controller.go 70.45% <0.00%> (ø)
hack/generated/main.go 0.00% <ø> (ø)
hack/generated/pkg/armclient/raw_client.go 56.52% <ø> (-2.61%) ⬇️
hack/generated/pkg/armclient/types.go 78.02% <ø> (+4.15%) ⬆️
hack/generated/pkg/genruntime/base_types.go 96.55% <ø> (ø)
hack/generated/pkg/genruntime/errors.go 40.90% <ø> (-36.37%) ⬇️
hack/generated/pkg/genruntime/property_bag.go 80.00% <ø> (ø)
...ck/generated/pkg/genruntime/resolved_references.go 50.00% <ø> (ø)
...ack/generated/pkg/genruntime/resource_reference.go 78.57% <ø> (+28.57%) ⬆️
...ted/pkg/reconcilers/azure_deployment_reconciler.go 66.58% <ø> (+8.36%) ⬆️
... and 222 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa558c...4debf24. Read the comment docs.

@Porges Porges merged commit 2578fbe into master Jul 4, 2021
@Porges Porges deleted the fix/integer-division-lint branch July 4, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants