Inject Hub() function on hub storage resources #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
Porges
reviewed
Jul 1, 2021
| @@ -153,6 +153,7 @@ func NewTestCodeGenerator(testName string, path string, t *testing.T, testConfig | |||
| "injectOriginalVersionFunction", | |||
| "injectOriginalVersionProperty", | |||
| "injectPropertyAssignmentFunctions", | |||
| pipeline.InjectHubFunctionStageId, | |||
There was a problem hiding this comment.
makes me think a pipeline function should take IDFactory (as well as Configuration?) so we don't need to have a building function that in turn calls MakeStage, so that this would be injectHubFunction.name
There was a problem hiding this comment.
I don't see how this would work - whether the factory methods return functions or objects, we don't have a reference to the value here, so we can't dereference it to access name. #pleaseexplainmore
Porges
approved these changes
Jul 1, 2021
theunrepentantgeek
force-pushed
the
feature/persist-apiversions
branch
from
6d73203 to
7319ad2
Compare
theunrepentantgeek
force-pushed
the
feature/hub-function
branch
2 times, most recently
from
93a5d65 to
8959fb7
Compare
theunrepentantgeek
force-pushed
the
feature/persist-apiversions
branch
from
74e3f6f to
3be33df
Compare
theunrepentantgeek
force-pushed
the
feature/hub-function
branch
from
8959fb7 to
157c4eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To support use of the
Convertibleinterface, the hub storage version needs to implement aHub()function. This pipeline stage modifies resources that have been flagged as "The storage version" by injecting this necessary function.How does this PR make you feel:
If applicable:
Requires PR #1606 to be merged first, as this reuses test support functions from that PR, and then rebasing on
master.Harvested from PR #1533.