Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the SQL server controller test which is failing pipeline tests #160

Merged
merged 28 commits into from
Aug 29, 2019
Merged

Removed the SQL server controller test which is failing pipeline tests #160

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f29f02f
feat: implement keyvault controller
alexeldeib Aug 7, 2019
30d70a0
Ace's KV changes with updates
jananivMS Aug 14, 2019
f4eadbb
Added an event for the final successful provisioning
jananivMS Aug 14, 2019
4893ac3
Updated changes based on the PR comments
jananivMS Aug 19, 2019
add1b86
removing unwanted file
jananivMS Aug 19, 2019
a3f4985
making resource group name the one in the keyvault yaml
jananivMS Aug 19, 2019
145fdce
Merge branch 'jananivMS-jananiv/kvchanges'
jananivMS Aug 19, 2019
0e91b3e
Fix merge conflicts
jananivMS Aug 19, 2019
1e26f3a
need to handled unexpected error types...like validation.error (#111)
frodopwns Aug 20, 2019
f5fd2cb
refactor tests (#90)
priyakumarank Aug 21, 2019
ea86ff6
Updates to KV controller from Ace (#80) (#112)
frodopwns Aug 21, 2019
93d3fb4
Test update (#115)
frodopwns Aug 21, 2019
0dd02d0
Feat/add consumer group kind (#117)
priyakumarank Aug 22, 2019
d02a81a
Updates to README - steps for onboarding (#114)
szoio Aug 22, 2019
39b0d04
Update azure-pipelines.yaml (#119)
priyakumarank Aug 22, 2019
594c5cd
fix tests (#140)
priyakumarank Aug 26, 2019
5223da9
Devcontainer to Help Onboard New People (#142)
JasonTheDeveloper Aug 26, 2019
5b6278d
pass future where possible instead of bool (#121)
WilliamMortlMicrosoft Aug 26, 2019
15d092d
randomize the resources names used in tests (#152)
priyakumarank Aug 28, 2019
c22f7c0
Ability to Set SecretName When Creating Event Hub (#151)
JasonTheDeveloper Aug 28, 2019
4d82777
Merge branch 'master' of https://github.com/Azure/azure-service-operator
jananivMS Aug 28, 2019
54b02ca
Merge branch 'azure-sql' of https://github.com/Azure/azure-service-op…
jananivMS Aug 28, 2019
5733c1c
merging
jananivMS Aug 29, 2019
94a9795
fixed issues with merge conflict
jananivMS Aug 29, 2019
fecea7f
Merge branch 'azure-sql' of https://github.com/Azure/azure-service-op…
jananivMS Aug 29, 2019
49609af
Merge branch 'azure-sql' of https://github.com/Azure/azure-service-op…
jananivMS Aug 29, 2019
724e4e3
fixing merge conflict markers in role yaml
jananivMS Aug 29, 2019
3e188c5
removing file
jananivMS Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- keyvaults
- consumergroups
verbs:
- create
Expand All @@ -21,6 +22,27 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- sqldatabases/status
verbs:
- get
- patch
- update
- apiGroups:
- apps
resources:
- deployments
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
resources:
- secrets
- resourcegroups/status
verbs:
- get
Expand All @@ -29,7 +51,7 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- sqlfirewallrules
- consumergroups
verbs:
- create
- delete
Expand All @@ -41,15 +63,16 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- sqlfirewallrules/status
- eventhubs/status
verbs:
- get
- patch
- update
- apiGroups:
- azure.microsoft.com
- ""
resources:
- secrets
- eventhubnamespaces
verbs:
- create
- delete
Expand All @@ -59,6 +82,9 @@ rules:
- update
- watch
- apiGroups:
- azure.microsoft.com
resources:
- eventhubnamespaces/status
- ""
resources:
- events
Expand All @@ -76,6 +102,7 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- keyvaults/status
- eventhubnamespaces/status
verbs:
- get
Expand All @@ -84,6 +111,7 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- sqldatabases
- keyvaults
verbs:
- create
Expand All @@ -96,12 +124,16 @@ rules:
- apiGroups:
- azure.microsoft.com
resources:
- sqlservers/status
- keyvaults/status
verbs:
- get
- patch
- update
- apiGroups:
- apps
resources:
- deployments/status
- azure.microsoft.com
resources:
- resourcegroups
Expand Down Expand Up @@ -181,17 +213,20 @@ rules:
- update
- watch
- apiGroups:
- azure.microsoft.com
- ""
resources:
- eventhubnamespaces
verbs:
- create
- delete
- watch
- apiGroups:
- azure.microsoft.com
resources:
- consumergroups/status
verbs:
- get
- list
- patch
- update
- watch
- apiGroups:
- azure.microsoft.com
resources:
Expand All @@ -201,7 +236,7 @@ rules:
- patch
- update
- apiGroups:
- apps
- azure.microsoft.com
resources:
- deployments
verbs:
Expand Down
1 change: 0 additions & 1 deletion controllers/eventhubnamespace_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ var _ = Describe("EventHubNamespace Controller", func() {
})

It("should create and delete namespace in k8s", func() {

eventhubNamespaceName := "t-ns-dev-eh-" + helpers.RandomString(10)

var err error
Expand Down
5 changes: 4 additions & 1 deletion controllers/sqlserver_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@ package controllers

import (
"context"

azurev1 "github.com/Azure/azure-service-operator/api/v1"
helpers "github.com/Azure/azure-service-operator/pkg/helpers"
resoucegroupsresourcemanager "github.com/Azure/azure-service-operator/pkg/resourcemanager/resourcegroups"
. "github.com/onsi/ginkgo"

//v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"time"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

. "github.com/onsi/gomega"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/types"
Expand Down