Update aad-pod-identity helm chart dependency to 4.1.1 #1583
Conversation
babbageclunk
requested review from
davefellows,
matthchr,
Porges and
theunrepentantgeek
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 183 183
Lines 11914 11914
=======================================
Hits 7535 7535
Misses 3706 3706
Partials 673 673 Continue to review full report at Codecov.
|
| appVersion: 1.0.24492 | ||
| description: Deploy components and dependencies of azure-service-operator | ||
| home: https://github.com/Azure/azure-service-operator | ||
| sources: | ||
| - https://github.com/Azure/azure-service-operator | ||
| dependencies: | ||
| - name: aad-pod-identity | ||
| version: 1.5.5 | ||
| version: 4.1.1 |
There was a problem hiding this comment.
This is a massive version bump!
There was a problem hiding this comment.
It gave me a fright at first as well but it's not quite as bad as it sounds. The aad-pod-identity chart version used to be in lock-step with the underlying package version but they floated it at some point - the actual aad-pod-identity version is going from 1.5.5 to 1.8.0.
There was a problem hiding this comment.
I think we need to fix the content of charts/azure-service-operator/values.yaml because AAD Pod Identity change the format to specify an identity from what we're using there to a new format. I filed a bug to them about difficulty doing that here, which they resolved a while back.
babbageclunk
force-pushed
the
update-aad-pod-identity-dep
branch
2 times, most recently
from
0cb2700 to
fd00039
Compare
babbageclunk
force-pushed
the
update-aad-pod-identity-dep
branch
15 times, most recently
from
4629294 to
5386c78
Compare
This corresponds to aad-pod-identity version 1.8.0. It's needed because the previous version 1.5.5 installs v1beta1 ClusterRoleBindings, which trigger deprecation warnings in k8s 1.19.11.
babbageclunk
force-pushed
the
update-aad-pod-identity-dep
branch
from
5386c78 to
b482f05
Compare
Closes #1364
What this PR does / why we need it:
Updates the aad-pod-identity dependency in our helm chart to 4.1.1. This corresponds to aad-pod-identity version 1.8.0. It's needed because the previous version 1.5.5 installs v1beta1
ClusterRoleBindings, which trigger deprecation warnings in k8s 1.19.11.Unfortunately this isn't the only thing that causes deprecation warnings in 1.19.11. Updating the version of cert-manager we install in CI and point to in docs is easy. We also need to change the
ValidatingWebhookConfigurations to v1 (which is blocked by controller-runtime at the moment)Special notes for your reviewer:
To avoid picking up changes to CRDs after the helm chart was released (which won't be handled by the current 1.0.24492 operator image) I made the dependency changes and ran the make target against the last helm chart update commit d28ea4b, then created the commit on master. Maybe we should be tagging each chart commit with the chart version as well as tagging the release commits?
How does this PR make you feel:
