-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make validator and defaulter more extensible #1507
Conversation
I know this looks like a pretty large PR, but ~2300 lines are golden files and ~200 are just moving code to a new file, so there's really only 600 lines of new code here. |
Codecov Report
@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
+ Coverage 62.81% 63.73% +0.92%
==========================================
Files 165 169 +4
Lines 10925 11265 +340
==========================================
+ Hits 6862 7180 +318
- Misses 3419 3436 +17
- Partials 644 649 +5
Continue to review full report at Codecov.
|
e39f086
to
7eb179d
Compare
7eb179d
to
6fc2b85
Compare
Closes #1430? |
So it does! Added to the description |
As the code generator gets fully fleshed out, we're running into cases where we need to perform special validation or defaulting logic on all resources. Additionally, the ability to manually add to validations/defaults for certain resources will be needed.
See https://github.com/Azure/azure-service-operator/blob/master/docs/design/defaulter-validator.md for the design of this feature.
Closes #1430