Revert "fix tests" #143
Closed
Revert "fix tests" #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 594c5cd.
melonrush13
approved these changes
Aug 26, 2019
|
Working on an update to the tests to coincide with this |
|
closing this as its changes have been incorporated in another PR |
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
- Since the target of this project is Kubernetes and the
root was already using kerrors it seems to make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #140
Now that a release has been cut for cutomer, I'm reverting this. The tests need to be updated to accommodate this moving forward