Support resource types that aren't quite "really" resources #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
matthchr
force-pushed
the
feature/empty-body-resources
branch
from
5eb501f to
45cf1a3
Compare
|
This is related to #3398 |
|
/ok-to-test sha=45cf1a3 |
v2/tools/generator/internal/codegen/embeddedresources/remove_empty_objects.go
Outdated
Show resolved
Hide resolved
theunrepentantgeek
requested changes
Nov 7, 2023
matthchr
force-pushed
the
feature/empty-body-resources
branch
from
45cf1a3 to
e2b484c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
+ Coverage 53.10% 53.12% +0.01%
==========================================
Files 1286 1286
Lines 402000 402010 +10
==========================================
+ Hits 213496 213570 +74
+ Misses 157888 157828 -60
+ Partials 30616 30612 -4 ☔ View full report in Codecov by Sentry. |
|
/ok-to-test sha=e2b484c |
theunrepentantgeek
approved these changes
Nov 20, 2023
They have a HEAD rather than a GET and no body parameters
matthchr
force-pushed
the
feature/empty-body-resources
branch
from
e2b484c to
88a5e04
Compare
|
/ok-to-test sha=88a5e04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have a HEAD rather than a GET and no body parameters
If applicable: