Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIM: Generate types that have no body (e.g. ProductAPI) #3398

Closed
ross-p-smith opened this issue Oct 10, 2023 · 3 comments · Fixed by #3530
Closed

APIM: Generate types that have no body (e.g. ProductAPI) #3398

ross-p-smith opened this issue Oct 10, 2023 · 3 comments · Fixed by #3530
Assignees
@matthchr
Labels
microsoft.apimanagement Issues related to APIManagement resources
Milestone
v2.5.0

Comments

@ross-p-smith
Copy link
Contributor

There are a few APIM resources that are created with a PUT and no body. This causes them to not be generated.

Examples can be found in /workspaces/azure-service-operator/v2/specs/azure-rest-api-specs/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2022-08-01/apimproducts.json

  • ProductApi
  • ProductGroup
  • ProductSubscription
  • ProductPolicy
  • ProductTag
  • ProductWiki

We could change the generator to generate these types.
@matthchr matthchr self-assigned this Oct 13, 2023
@matthchr
Copy link
Member

I'm looking into this. I suspect the fix in the generator should be relatively easy.

@matthchr
Copy link
Member

I have this fixed locally but realized that one gotcha is that these resources don't actually have a GET, which we rely on in the reconciler currently. We need to fix that too.

Need some way to indicate at codegen time what operations a resource supports and then hook the operator in to looking at that. Shouldn't be too hard, will work on this as well.

@matthchr matthchr added this to the v2.4.0 milestone Oct 16, 2023
@tomkerkhove
Copy link
Member

#2747 depends on this

This was referenced Nov 7, 2023
Merged
Merged
Merged
@matthchr matthchr added the microsoft.apimanagement Issues related to APIManagement resources label Nov 9, 2023
@ross-p-smith ross-p-smith mentioned this issue Nov 14, 2023
Merged
2 tasks
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.4.0, v2.5.0 Nov 14, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Nov 19, 2023
@matthchr matthchr moved this from Recently Completed to Ready for Release in Azure Service Operator Roadmap Nov 20, 2023
@ross-p-smith ross-p-smith mentioned this issue Dec 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthchr matthchr

Labels
microsoft.apimanagement Issues related to APIManagement resources
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Controller should use HEAD if GET is not available matthchr/azure-service-operator
4 participants
@theunrepentantgeek @tomkerkhove @ross-p-smith @matthchr