Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageTypeFactory assumes that types do not reference one another across group boundaries #1578

Closed
matthchr opened this issue Jun 18, 2021 · 0 comments · Fixed by #1579
Closed

StorageTypeFactory assumes that types do not reference one another across group boundaries #1578

matthchr opened this issue Jun 18, 2021 · 0 comments · Fixed by #1579
Milestone
codegen-alpha-0

Comments

@matthchr
Copy link
Member

Describe the current behavior
Today, in the createStorageTypes pipeline stage, a StorageTypeFactory is created for each group, and is populated with all of the types in that group. The types collection built up for each StorageTypeFactory contains only types from that group.

This disallows any cross-group type references, which I think is reasonable, except that there are instances of cross-group references - for example microsoft.compute refers to microsoft.compute.extensions - see the VirtualMachineScaleSetExtension type.

Describe the improvement
Either StorageTypeFactory needs to tolerate this layout, or we need to come up with a stage that automatically does a graph-walk and moves things that have cross-group dependencies into mirrored types in the same group.
@matthchr matthchr added the task label Jun 18, 2021
@matthchr matthchr added this to the codegen-alpha-0 milestone Jun 18, 2021
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jun 19, 2021
@matthchr
Add new pipeline stage that merges groups
7bfe460 
  - In the case that group A references group B, we need to
    pull group B's types into group A.
  - Fixes Azure#1578
@matthchr matthchr mentioned this issue Jun 19, 2021
Merged
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jun 21, 2021
@matthchr
Add new pipeline stage that merges groups
9b7a8b9 
  - In the case that group A references group B, we need to
    pull group B's types into group A.
  - Fixes Azure#1578
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jun 23, 2021
@matthchr
Add new pipeline stage that merges groups
7939833 
  - In the case that group A references group B, we need to
    pull group B's types into group A.
  - Fixes Azure#1578
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Jun 23, 2021
@matthchr
Add new pipeline stage that merges groups
1e00474 
  - In the case that group A references group B, we need to
    pull group B's types into group A.
  - Fixes Azure#1578
matthchr added a commit that referenced this issue Jun 24, 2021
@matthchr
Add new pipeline stage that merges groups (#1579)
d420499 
  - In the case that group A references group B, we need to
    pull group B's types into group A.
  - Fixes #1578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
codegen-alpha-0
Development

Successfully merging a pull request may close this issue.

Add new pipeline stage that merges groups matthchr/azure-service-operator
1 participant
@matthchr