Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 9950 #8589

Merged
merged 4 commits into from
Mar 1, 2025
+7 −7
Merged

Sync eng/common directory with azure-sdk-tools for PR 9950 #8589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0343ee6
Use PME for esrp release
hallipr Feb 24, 2025
be71b0d
Update to EsrpRelease@9
hallipr Feb 25, 2025
39b61b7
Remove extra DomainTenantId parameter
hallipr Feb 25, 2025
74147b3
Add PME service connection to pipelines
hallipr Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions eng/common/pipelines/templates/archetype-typespec-emitter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,22 +172,22 @@ extends:

- ${{ if parameters.PublishPublic }}:
# publish to npmjs.org using ESRP
- task: EsrpRelease@7
- task: EsrpRelease@9
inputs:
displayName: Publish to npmjs.org
ConnectedServiceName: Azure SDK Engineering System
ConnectedServiceName: Azure SDK PME Managed Identity
ClientId: 5f81938c-2544-4f1f-9251-dd9de5b8a81b
KeyVaultName: AzureSDKEngKeyVault
AuthCertName: azure-sdk-esrp-release-auth-certificate
SignCertName: azure-sdk-esrp-release-sign-certificate
DomainTenantId: 975f013f-7f24-47e8-a7d3-abc4752bf346
UseManagedIdentity: true
KeyVaultName: kv-azuresdk-codesign
SignCertName: azure-sdk-esrp-release-certificate
Intent: PackageDistribution
ContentType: npm
FolderLocation: $(buildArtifactsPath)/packages
Owners: ${{ coalesce(variables['Build.RequestedForEmail'], '[email protected]') }}
Approvers: ${{ coalesce(variables['Build.RequestedForEmail'], '[email protected]') }}
ServiceEndpointUrl: https://api.esrp.microsoft.com
MainPublisher: ESRPRELPACMANTEST
DomainTenantId: 72f988bf-86f1-41af-91ab-2d7cd011db47

- task: PowerShell@2
displayName: Create emitter-package.json
Expand Down
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/jobs/prepare-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
$generateUnifiedWeekly = 'false'
$testServiceConnections = '"Azure" "azure-sdk-tests" "azure-sdk-tests-preview" "azure-sdk-tests-public" "Azure SDK Test Resources - LiveTestSecrets"'
$internalServiceConnections = '"Azure" "Azure SDK Artifacts" "Azure SDK Engineering System" "opensource-api-connection" "AzureSDKEngKeyVault Secrets"'
$internalServiceConnections = '"Azure" "Azure SDK Artifacts" "Azure SDK Engineering System" "opensource-api-connection" "AzureSDKEngKeyVault Secrets" "Azure SDK PME Managed Identity"'
# Map the language to the appropriate variable groups
switch ($lang)
Expand Down