Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust and other fixes to CODEOWNERS #8510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heaths
Copy link
Member

@heaths heaths commented Feb 7, 2025

No description provided.

@heaths heaths requested a review from a team as a code owner February 7, 2025 23:41
@heaths heaths enabled auto-merge (squash) February 7, 2025 23:41
@heaths
Copy link
Member Author

heaths commented Feb 8, 2025

The linter error seems overzealous. We can't update a CODEOWNER for what will exist and have to wait - and remember - to modify it later?

@weshaggard
Copy link
Member

The linter error seems overzealous. We can't update a CODEOWNER for what will exist and have to wait - and remember - to modify it later?

We had the linter do that because so many paths don't exist or get deleted. I would prefer to wait until we have those files.

@heaths
Copy link
Member Author

heaths commented Feb 10, 2025

@hallipr is everything hooked up such that these package release files will get created if I were to run release-package.ps1?

@weshaggard I don't see the harm in overriding this. These files will exist. Why do I need to come back later to fix everything when I can do it in one shot now? /cc @RickWinter

@weshaggard
Copy link
Member

@heaths you will cause the night job for the linter to break. I suggest adding them later or just holding on merging this PR until they exist.

As for the package index files for rust that takes additional work that will probably come later as I told @hallipr to wait until we actually get some packages before enabling the rust language in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants