Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential changes to Rules for AI Triage Service #9964

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tools/github-event-processor/RULES.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ _**Predictions made**_

```json
{
"labels": [
"labels" : [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest that we break this out into the 4 possible states with examples for each:

  • Manual triage needed. (empty labels, no suggestions, no solution)
  • Label prediction made for triage. (labels populated, no suggestion, no solution)
  • Label prediction with suggestion (labels populated, suggestion populated, no solution)
  • Label prediction with solution (labels populated, no suggestion, solution populated)

"Storage",
"Client"
]
],
"suggestion" : string | null,
"solution" : string | null
Comment on lines +77 to +78
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"suggestion" : string | null,
"solution" : string | null
"suggestion" : null,
"solution" : null

}
```

Expand Down Expand Up @@ -118,8 +120,9 @@ IF labels were predicted:
- Create the following comment, mentioning all AzureSdkOwners from the set
"@{person1} @{person2}...${personX}"

- Create the following comment
"Thank you for your feedback. Tagging and routing to the team member best able to assist."
IF solution and suggestion are not populated
- Create the following comment
"Thank you for your feedback. Tagging and routing to the team member best able to assist."

# Note: No valid AzureSdkOwners means there were no CODEOWNERS entries for the service label OR no
# CODEOWNERS entries for the service label with AzureSdkOwners OR there is a CODEOWNERS entry with
Expand All @@ -133,6 +136,12 @@ IF labels were predicted:
IF "needs-team-triage" is not being added to the issue
- Add "needs-team-attention" label to the issue

IF suggestions is populated
- Comment with suggestion
ELSE IF solution is populated
- Comment with solution
- Add "issue-addressed" label to issue

ELSE
- Add "needs-triage" label to the issue

Expand Down