Python API review is not generated using correct package name #9954
+31
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
the
Central-EngSys
praveenkuttappan
requested review from
lmazuel,
tjprescott,
scbedd and
swathipil
swathipil
reviewed
Mar 3, 2025
packages/python-packages/apiview-stub-generator/apistub/_stub_generator.py
Outdated
Show resolved
Hide resolved
swathipil
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API parser has a new change to get package name and version using pkginfo and this only works when gnerating review file from wheel or sdist. But python CI generates token from package source hence pkginfo is not available and as a result review token file is generated with wrong version and wrong token file name.
Parser also iterates all directories including tests and build and include those paths in package modules.