Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipeline generation for private repos #9698

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix pipeline generation for private repos #9698

merged 2 commits into from
Feb 4, 2025

Conversation

weshaggard
Copy link
Member

Pipeline generation for the private repos no longer works after my recent refactoring. The reason is because sparse-checkout doesn't support cloning them without a key. I've hacked together a proof of concept to unblock folks but I'm not sure how I like this implementation.

I'm curious of your thoughts @benbp

@weshaggard weshaggard requested a review from benbp January 24, 2025 18:43
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member Author

test run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4520016&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=5431112d-2b61-5a5f-7042-ef698f761043

@weshaggard weshaggard marked this pull request as ready for review January 30, 2025 00:54
@weshaggard weshaggard requested a review from a team as a code owner January 30, 2025 00:54
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 4, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 4, 2025
@azure-sdk @weshaggard
Sync eng/common directory with azure-sdk-tools for PR 9698 (#32860)
0bc09c7 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9698 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Wes Haggard <[email protected]>
@weshaggard weshaggard merged commit 9520a09 into main Feb 4, 2025
8 checks passed
@weshaggard weshaggard deleted the weshaggard-patch-1 branch February 4, 2025 01:23
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weshaggard @azure-sdk @benbp