Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Typespec API reviews #9611

Merged

Conversation

praveenkuttappan
Copy link
Member

Add support to convert TypeSpec reviews from old json model to new model.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Jan 9, 2025
@praveenkuttappan praveenkuttappan self-assigned this Jan 9, 2025
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add tests for this?

@praveenkuttappan
Copy link
Member Author

Added test case for conversion. @maririos Can you please approve this PR?

@praveenkuttappan praveenkuttappan merged commit 5d1000e into Azure:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants