[tsp-client] Float @azure-tools/openapi-to-typespec dep #9602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinaperalta
commented
Jan 8, 2025
|
@mikeharder I noticed that checkenforcer doesnt complete on tsp-client PRs, I believe it's because it doesnt know that the GH action has finished the checks, do you know how we can fix that? I've had to evaluate or override to merge PRs |
pshao25
reviewed
Jan 8, 2025
mikeharder
approved these changes
Jan 8, 2025
2 tasks
pshao25
approved these changes
Jan 9, 2025
…tsp-client/float-converter
|
/check-enforcer evaluate |
This was referenced Jan 20, 2025
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Feb 7, 2025
After this PR Azure/azure-sdk-tools#9602, `@autorest/openapi-to-typespec` no longer updated with tsp-client. Customers need to update themselves every time when `@autorest/openapi-to-typespec` release. This document update is to guide customers how to updadte. --------- Co-authored-by: Pan Shao <[email protected]>
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Feb 7, 2025
After this PR Azure/azure-sdk-tools#9602, `@autorest/openapi-to-typespec` no longer updated with tsp-client. Customers need to update themselves every time when `@autorest/openapi-to-typespec` release. This document update is to guide customers how to updadte. --------- Co-authored-by: Pan Shao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsp-client doesn't need to rely on a specific version of this dependency. Will float the dep up to GA for now, so that users can specify the version of the package they wish to use.
@pshao25 instead of pinning the openapi-to-typespec dependency in tsp-client you will pin it in the azure-rest-api-specs package.json to update versions.