Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new interfaces #9474

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Support new interfaces #9474

merged 4 commits into from
Dec 12, 2024

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Dec 5, 2024 •
edited
Loading

  • Support new input in schema.ts.
  • Removed dependencies @azure/identity and @azure/storage-blob from package.json and package-lock.json.
  • Refactored entrypoint.ts to remove unused imports and update logging and context initialization.
  • Added functionality to generate and save execution reports in reportStatus.ts.
  • Updated logging mechanism to use file logging instead of Azure Blob Storage in logging.ts.
  • Support the local SDK generation logic in workflow.ts and workflowPackage.ts.

@raych1 raych1 linked an issue Dec 5, 2024 that may be closed by this pull request
Support interface changes in the spec-gen-sdk tool #9433
Closed
@raych1 raych1 marked this pull request as ready for review December 9, 2024 19:00
@raych1 raych1 requested a review from weshaggard December 9, 2024 19:00
@raych1
Copy link
Member Author

raych1 commented Dec 9, 2024

@weshaggard could you review this PR? Please note that the change to support spec PR scenario including the change of how to calculate the change files in a spec PR will be in a separated pull request.

weshaggard
weshaggard approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but seems reasonable.

I know this is still a work in progress but it will be much easier to understand once we see the reporting in action from the various scenarios.

@raych1 raych1 merged commit 9816a06 into main Dec 12, 2024
15 checks passed
@raych1 raych1 deleted the user/raych1/new-contract branch December 12, 2024 18:02
@raych1 raych1 added the Central-EngSys This issue is owned by the Engineering System team. label Dec 12, 2024
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu chidozieononiwu is a code owner

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@mikeharder mikeharder Awaiting requested review from mikeharder

Assignees
No one assigned
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support interface changes in the spec-gen-sdk tool
2 participants
@raych1 @weshaggard