Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Basic Detection for RLC #9209

Merged
merged 19 commits into from
Oct 29, 2024

Conversation

wanlwanl
Copy link
Member

@wanlwanl wanlwanl commented Oct 17, 2024

Features

  • General interface breaking change detection, including Routes in RLC
  • General function and function overloads' breaking change detection: . e.g. IsUnexpected
  • Type alias breaking changes detection

Fixes

  • export type A = "X" | "Y" -> export type A ="X" | "y" cannot be detected
  • Except for intersection type, type alias changes cannot be detected
  • Emoved type alias cannot be detected
  • Routes changes cannot be detected
  • Function and function overloads cannot be detected

Notes

  • Corner cases are waiting for review, see loop, therefore, findBreakingReasons function in declaration-diff.ts file may be inaccurate. Except for this, the PR is ready for review

@wanlwanl wanlwanl marked this pull request as ready for review October 17, 2024 04:22
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge when the comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants