Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Package Folder Before Generation #8826

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Clear Package Folder Before Generation #8826

merged 3 commits into from
Aug 13, 2024

Conversation

wanlwanl
Copy link
Member

@wanlwanl wanlwanl commented Aug 13, 2024 •
edited
Loading

MaryGao
MaryGao approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small comments!

Regarding the customization code I remember Ray has mentioned we could improve our automation to have message like The SDK has customized SDK code and might not be compatible with the new specs, the service team may need to update the customized code or the new specs. Not sure this is feasible and we have plan for this.

@wanlwanl
Copy link
Member Author

Left small comments!

Regarding the customization code I remember Ray has mentioned we could improve our automation to have message like The SDK has customized SDK code and might not be compatible with the new specs, the service team may need to update the customized code or the new specs. Not sure this is feasible and we have plan for this.

The current customized code is mixed in generated code, we don't know if customer has customized code. I think it's better to seperate generated code and customized code in the future.

@wanlwanl wanlwanl merged commit 7bd7a29 into main Aug 13, 2024
7 checks passed
@wanlwanl wanlwanl deleted the wanl/delete-before-gencode branch August 13, 2024 08:11
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK Automation - JS] Support SDK generation in CI pipeline for the services migrated from Swagger to TypeSpec
2 participants
@wanlwanl @MaryGao