Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for AreAPICodeFilesTheSame #8652

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix logic for AreAPICodeFilesTheSame #8652

merged 1 commit into from
Jul 17, 2024

Conversation

chidozieononiwu
Copy link
Member

  • Fix bug in AreAPICodeFilesTheSame

scbedd
scbedd approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment •
edited by chidozieononiwu
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makse sense. Function returns true if the files are the same, but we were returning the reverse.

@chidozieononiwu chidozieononiwu merged commit 61a7aa1 into Azure:main Jul 17, 2024
9 checks passed
WhitShake pushed a commit to WhitShake/azure-sdk-tools that referenced this pull request Jul 24, 2024
@chidozieononiwu @WhitShake
Fix logic for AreAPICodeFilesTheSame (Azure#8652)
6ee4749
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @scbedd