Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unified Pipeline APIView Release #8383

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Add Unified Pipeline APIView Release #8383

merged 11 commits into from
Jun 13, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jun 5, 2024

This is related to #7941

This PR eliminates the need for the following standalone releases, and ensures that APIView is compliant with security needs.

When queuing manually from internal, users will be prompted for a target environment prod or staging. staging enables access to #1 and #2 in the list above. prod enables #3 only.

Ready to test the actual releases.

New Stage Flow

Build and Test -> Staging (automatic) -> Production (approve required)
               -> Test UI (approve required)

@scbedd scbedd self-assigned this Jun 5, 2024
@scbedd scbedd marked this pull request as ready for review June 5, 2024 22:02
@scbedd scbedd requested a review from chidozieononiwu as a code owner June 5, 2024 22:02
@scbedd scbedd mentioned this pull request Jun 5, 2024
41 tasks
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Only additional change I prefer to have is to support deployment of just the UI test instance.

Currently following are the deployment patterns.

  1. APIView UI test is deployed for some testing and demo purposes (Less frequent deployment).
  2. APIView stage gets auto deployed anytime a new change is merged to main branch. So staging can be run pretty much as a CI job.
  3. APIView production deployment is done manually.

@scbedd
Copy link
Member Author

scbedd commented Jun 11, 2024

Looks fine. Only additional change I prefer to have is to support deployment of just the UI test instance.

Currently following are the deployment patterns.

  1. APIView UI test is deployed for some testing and demo purposes (Less frequent deployment).
  2. APIView stage gets auto deployed anytime a new change is merged to main branch. So staging can be run pretty much as a CI job.
  3. APIView production deployment is done manually.

Ok Praveen, I've made the following adjustments.

  1. Staging auto publishes to staging if the build is from internal
  2. Releases always flow through staging first
  3. Manually queue the build to get access to stage Publish Test UI and Publish to Production APIView

Please give a more detailed look at the release stages, then I'm going to pull the trigger on this thing :D

Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scbedd
Copy link
Member Author

scbedd commented Jun 12, 2024

Awaiting one last deployment to production slot, then this is ready to merge.

@scbedd
Copy link
Member Author

scbedd commented Jun 13, 2024

image
Merging!

@scbedd scbedd merged commit 4affa36 into main Jun 13, 2024
13 checks passed
@scbedd scbedd deleted the api-view-release branch June 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants