-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unified Pipeline APIView Release #8383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Only additional change I prefer to have is to support deployment of just the UI test instance.
Currently following are the deployment patterns.
- APIView UI test is deployed for some testing and demo purposes (Less frequent deployment).
- APIView stage gets auto deployed anytime a new change is merged to main branch. So staging can be run pretty much as a CI job.
- APIView production deployment is done manually.
…Publish Test UI and Production Publish stages manual approval
Ok Praveen, I've made the following adjustments.
Please give a more detailed look at the release stages, then I'm going to pull the trigger on this thing :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Awaiting one last deployment to production slot, then this is ready to merge. |
This is related to #7941
This PR eliminates the need for the following standalone releases, and ensures that APIView is compliant with security needs.
When queuing manually from
internal
, users will be prompted for a target environmentprod
orstaging
.staging
enables access to #1 and #2 in the list above.prod
enables #3 only.Ready to test the actual releases.
New Stage Flow