Add static file secret-less sub-config support #8319
Conversation
danieljurek
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
This can merge once I can verify the final state of the PR against the ephemeral test subscription. |
|
The following pipelines have been queued for testing: |
|
@danieljurek @weshaggard what is the need for the sub config file path parameter, and how is it different from https://github.com/Azure/azure-sdk-tools/tree/main/eng/common/TestResources/clouds? Or are we changing the path? I'm not a fan of this extra config field it seems unnecessary and something that could be inferred, but I don't think I have enough detail. |
Our goal is to move the subscription configurations as files into the repo instead of in the KV. Now that they will not contain any secrets there is no reason we cannot have that configuration in the repo. I believe the cloud configurations can be used as well and we should definitely not duplicate that information, but the sub-configs will have information about the subscription and tenants that will be needed. |
|
Chatted with Wes. I'm on board LGTM. |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8319 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Example successful pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3825341&view=results
Example wiring up in
tests.ymlhttps://github.com/Azure/azure-sdk-for-net/compare/main...djurek%2Fworkload-identity-live-tests-sub-config-files?body=&expand=1#diff-a38d5bba40ecff60e025723b70c9a682e464bcadf5e87e6571a641ca8659dee3R9-R12Testing .NET appconfig in its current state (no federated auth) to ensure no wider regression: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3811807&view=logs&j=d1b595c4-8536-5d61-1a0c-a149c6a83c63&t=20c529b1-7692-5b7f-3681-519a295cdefc