Only save package properties for track 2 packages #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of track 2 package info by track 1 packages)
danieljurek
requested review from
konrad-jamrozik,
weshaggard and
benbp
as code owners
weshaggard
reviewed
Jul 19, 2023
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
weshaggard
reviewed
Jul 19, 2023
|
|
||
| # If package properties for a track 2 (IsNewSdk = true) package has | ||
| # already been written, skip writing to that same path. | ||
| if ($exportedPaths.ContainsKey($outputPath) -and $exportedPaths[$outputPath].IsNewSdk -eq $true) { |
There was a problem hiding this comment.
FWIW I do some similar at https://github.com/Azure/azure-sdk/blob/main/eng/scripts/PackageList-Helpers.ps1#L270
weshaggard
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 20, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6544 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Daniel Jurek <[email protected]>
dgetu
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Sep 6, 2023
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#6544 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Daniel Jurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents overwrites of track 2 package info by track 1 packages.