Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeownersEntry.GetHashCode support Enumerables #5636

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Mar 6, 2023

As in subject.

Candidate to be added to:

Note I didn't change the type of CodeownersEntry to record as it would not help, per this doc:

Two variables of a class type are equal if the objects referred to are the same class type and the variables refer to the same object.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable.

@konrad-jamrozik konrad-jamrozik merged commit aba9602 into main Mar 6, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/coentry_eq branch March 6, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants