Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete GHCreator and its usages #5042

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Jan 4, 2023

This PR removes obsolete GHCreator. This PR is required to complete the work for:

I deleted .gitignore because the only rule it had was:

# Output from the GHCreator tool
fileLog.txt

How to navigate this PR diff

Search for https://github.com/Azure/azure-sdk-tools/pull/5042 to see where previous GHCreator usages need to be replaced.

@konrad-jamrozik konrad-jamrozik self-assigned this Jan 4, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jan 4, 2023
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @jsquire on this one.

@jsquire
Copy link
Member

jsquire commented Jan 4, 2023

Before this PR can be merged, the tools/github-labels needs to be migrated to use GH CLI, per #4888 (comment).

To clarify, you can merge whenever. I need to port the script over to the GH CLI regardless and nobody else is using it in the meantime.

@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review January 4, 2023 22:54
@konrad-jamrozik konrad-jamrozik requested a review from a team as a code owner January 4, 2023 22:54
@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit f114ff8 into main Jan 4, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/delete_GHCreator branch January 4, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants