Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostic output + refactor handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml #5007

Merged
merged 8 commits into from
Jan 4, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Dec 21, 2022

This PR addresses following comment:

Changes made

  • added variable to deduplicate $(Build.ArtifactStagingDirectory)/packages;
  • now listing contents of $(Build.ArtifactStagingDirectory)/packages;
  • made improvements to task message and name;
  • also improved the name and diagnostic output of Create destination directory task, coming from produce-net-standalone-packs.yml, as it was too vague and misleading.

Testing done

Tested by making a build from this PR branch and observing it behaved correctly:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 21, 2022
@konrad-jamrozik konrad-jamrozik requested a review from a team as a code owner December 21, 2022 02:51
@konrad-jamrozik konrad-jamrozik self-assigned this Dec 21, 2022
@konrad-jamrozik konrad-jamrozik changed the title List out contents of packages-to-be-published directory List out contents of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Dec 21, 2022
@konrad-jamrozik konrad-jamrozik changed the title List out contents of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Make improvements to handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Dec 21, 2022
@konrad-jamrozik konrad-jamrozik changed the title Make improvements to handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Improve handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Dec 21, 2022
@konrad-jamrozik konrad-jamrozik changed the title Improve handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Improve diagnostic output + refactor handling of packages-to-be-published directory in archetype-sdk-tool-dotnet.yml Dec 21, 2022
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @konrad-jamrozik !

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 9ef966d into main Jan 4, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/pr4916_ps1 branch January 4, 2023 01:37
}
displayName: Create directory for packages to publish if absent
displayName: Create XOR list contents of directory of packages to publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XOR -> or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants