Assorted set of minor refactorings for logic related to CODEOWNERS processing #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
weshaggard
reviewed
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for making changes for #2770 I submit this PR with a set of assorted refactorings on
tools/code-owners-parser/CodeOwnersParser.slnandtools/notification-configuration/notification-configuration.sln.Here is what I did on both of these solutions:
readonlyattributes, fixing member capitalization to match official convention (which also matches the convention used by majority of the codebase), and removing unusedusingstatements and fixing typos.*.sln.DotSettings.Azure.Sdk.Tools.RetrieveCodeOwners.Tests.MainTests.CodeOwnerFilePathtoCodeOwnersFilePath.CodeOwnersParser.sln.