Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new branch for quing the TestPipeline, this should prevent chec… #1154

Merged

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Oct 29, 2020

Use a new branch for queueing the TestPipeline, this should prevent template checks from showing up on eng/common Sync PRs.
Add step tp clean up upstream branches used during the sync run.
Add retry logic to the verify and merge stage.

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner October 29, 2020 02:57
@check-enforcer-staging
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch 6 times, most recently from 7a8cb6b to b032f10 Compare October 29, 2020 21:30
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch from b032f10 to 4811b72 Compare October 30, 2020 00:49
@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch 2 times, most recently from 14fffc0 to 392b41f Compare October 30, 2020 16:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch from af27c9f to 77da704 Compare October 30, 2020 22:52
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch from 77da704 to fc1c6ed Compare October 31, 2020 01:01
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the bugfix/RemoveTestPipelineFromPRChecks branch from fc1c6ed to 6b0f684 Compare October 31, 2020 02:14
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 31, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 6012199 into Azure:master Oct 31, 2020
benbp pushed a commit that referenced this pull request Dec 1, 2020
#1154)

Use a new branch for queueing the TestPipeline, this should prevent template checks from showing up on `eng/common` Sync PRs.
Add step tp clean up upstream branches used during the sync run.
Add retry logic to the verify and merge stage.
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants