Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a dedicated pipeline for running tests in /eng/scripts/ + fix naming convention #5878

Open
konrad-jamrozik opened this issue Mar 31, 2023 · 0 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Mar 31, 2023

Work to do as outlined in this comment.

Relevant pipeline that needs update:

Currently its responsibility of running tests in /eng/scripts is handled by:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Mar 31, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Mar 31, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🤖🧠 Mar 31, 2023
@konrad-jamrozik konrad-jamrozik changed the title Have a dedicated pipeline for running tests in /eng/scripts/ Have a dedicated pipeline for running tests in /eng/scripts/ + fix naming convention Mar 31, 2023
ghost pushed a commit that referenced this issue Mar 31, 2023
…vements & cleanup (#5608)

This PR moves the `Test` flag away from `get-codeowners.ps1` to the established `eng/common-tests` infrastructure, using PowerShell Pester testing framework. As such, it solves:

- #5434

This PR also:
- adds a README for the `eng/common-tests`;
- extracts the `get-codeowners.lib.ps1`, so that the functions can be reused between normal `get-codewners.ps1` usage and through Pester unit test invocations coming from `get-codeowners.tests.ps1`;
- changes some paths for related scripts and test scripts;
- moves some default params to `get-codeowners.lib.ps1` and hides some unused params; this was necessary to avoid default param value duplication between calls from `get-codeowners.ps1` and from `get-codeowners.tests.ps1`;
- applies some refactorings.

Associated changes made manually once this PR got merged:

- deleted internal pipeline [tools - eng-common-tests](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2605155&view=results); instead, created the public equivalent: [tools - eng-common-tests - ci](https://dev.azure.com/azure-sdk/public/_build?definitionId=5985).
  - For context, see [this comment](#5608 (comment)).

Follow-up work:
- #5878
@konrad-jamrozik konrad-jamrozik moved this from 🐝 Dev to 📋Backlog in Azure SDK EngSys 🤖🧠 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant