bump (#9863)

Azure · Feb 19, 2025 · d784f16 · d784f16
1 parent 4672d17
commit d784f16
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 18 deletions.
diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/CHANGELOG.md b/tools/pylint-extensions/azure-pylint-guidelines-checker/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release History
 
+## 0.5.2 (2025-02-19)
+
+- Bug fix for `do-not-log-exceptions` checker, was incorrectly flagging debug logs.
+
 ## 0.5.1 (2025-01-23)
 
 - Bug Fix for connection_verify rule

diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py b/tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
@@ -2983,7 +2983,7 @@ def check_for_logging(self, node, exception_name):
             levels.
         """
         try:
-            levels_matches = [".warning", ".error", ".info", ".debug"]
+            levels_matches = [".warning", ".error", ".info"]
             for j in node:
                 if isinstance(j, astroid.Expr):
                     expression = j.as_string().lower()

diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/setup.py b/tools/pylint-extensions/azure-pylint-guidelines-checker/setup.py
@@ -6,7 +6,7 @@
 
 setup(
     name="azure-pylint-guidelines-checker",
-    version="0.5.1",
+    version="0.5.2",
     url="http://github.com/Azure/azure-sdk-for-python",
     license="MIT License",
     description="A pylint plugin which enforces azure sdk guidelines.",

diff --git a/tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py b/tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
@@ -3626,14 +3626,6 @@ def test_logging_levels_logged_str_exception(self, setup):
                 col_offset=8,
                 end_line=11,
                 end_col_offset=28,
-            ),
-            pylint.testutils.MessageTest(
-                msg_id="do-not-log-exceptions",
-                line=12,
-                node=debug_node,
-                col_offset=8,
-                end_line=12,
-                end_col_offset=29,
             )
         ):
             self.checker.visit_try(try_node)
@@ -3669,14 +3661,6 @@ def test_logging_levels_logged_repr_exception(self, setup):
                 col_offset=8,
                 end_line=22,
                 end_col_offset=29,
-            ),
-            pylint.testutils.MessageTest(
-                msg_id="do-not-log-exceptions",
-                line=23,
-                node=debug_node,
-                col_offset=8,
-                end_line=23,
-                end_col_offset=30,
             )
         ):
             self.checker.visit_try(try_node)