Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific minimum version of time dependency #978

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

bittrance
Copy link
Contributor

Switching to latest main version of the SDK in my latest project produced this compiler error:

error[E0599]: no method named `unsigned_abs` found for struct `time::Duration` in the current scope
   --> /home/bittrance/.cargo/git/checkouts/azure-sdk-for-rust-c7e81752dfd35dc6/c8ccf8d/sdk/core/src/date/mod.rs:138:22
    |
138 |     (first - second).unsigned_abs()
    |                      ^^^^^^^^^^^^ method not found in `time::Duration`

This is a consequence of the switch to the time crate as introduced in #965 which specifies time version 0.3. However, the method was introduced in time 0.3.10, see time-rs/time@c3df3f9 .

I'm not sure exactly what combination of dependencies in my project bounded time to version 0.3.9, but I'm thinking this SDK should declare a viable minimum version?

time::Duration::unsigned_abs was introduced in time 0.3.10
so manifests should not allow earlier versions.
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cataggar cataggar merged commit 7d308aa into Azure:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants