Migrate iothub to pipelines #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Aug 3, 2022
sdk/iot_hub/src/service/operations/create_or_update_device_identity.rs
Outdated
Show resolved
Hide resolved
sdk/iot_hub/src/service/operations/create_or_update_module_identity.rs
Outdated
Show resolved
Hide resolved
|
Thanks @rylev, adressed the PR comments, you'll have to do the merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #802
Migrating the iothub sdk to pipelines architecture.
I tried to retain the API surface. There are some methods that return generic
CollectedResponseand implement theTryIntofor a specific return type. In these cases I implemented the "async try_from" that is generally used on the type alias, as to not have conflicts / ambiguities. An example beingget_identityused for module and device identity methods.I also added an authorization policy along with the option to use identities for authorization. I never really worked with iothub, but looking at the docs it seems that is a valid auth method. Currently there is no way to specify client options, albeit them being used for constructing the pipeline. This was deliberate, as I understand a new builder pattern for the clients is being worked on and there were no options before as well.
Lastly I reused the timeout policy from storage and moved it to core.
@rylev @ctaggart