storage_blobs: Add support for snapshot blob. #966
Conversation
Add support to `BlobClient` for taking snapshots of a blob. For now this reuses the opaque type that already exists for `Snapshot`, but it might be worth considering adding support for treating it as a `DateTime`.
|
|
Sure thing. Is there a standard place to land those tests? Should get go in the actual It looks like https://github.com/Azure/azure-sdk-for-rust/blob/36d4d163beb4f2ba8e4fa732594307d75642caf5/sdk/data_cosmos/tests/setup.rs and the tests that use it are probably the best example to go by? Also, what do you think about relying more on the |
|
@gorzell indeed - the cosmos crate is the one to follow. Putting them in a separate tests directory is the way to go. I don't believe |
| } | ||
| } | ||
|
|
||
| pub const SNAPSHOT: HeaderName = HeaderName::from_static("x-ms-snapshot"); |
There was a problem hiding this comment.
Unsure if this is the right place for this. I'll think about it a bit more...
There was a problem hiding this comment.
It seemed like most of the other const of this type were in core which was a bit extreme for something storage specific. It could go in lib, or some other central place in the storage_blobs crate for sure.
There was a problem hiding this comment.
More specifically: https://github.com/gorzell/azure-sdk-for-rust/blob/main/sdk/core/src/headers/mod.rs
I think it would be fine to move this to a headers.rs file at the top level of storage_blob.
|
|
||
| let snapshot = blob.snapshot().into_future().await.unwrap().snapshot; | ||
|
|
||
| trace!("crated snapshot: {:?} of {:?}", snapshot, BLOB_NAME); |
There was a problem hiding this comment.
It would be nice to assert something here about the snapshot. Otherwise we're only testing that the deserialization doesn't outright fail.
There was a problem hiding this comment.
I'll think about this, but it is a bit tricky since you get back an "opaque" value that happens to be a timestamp. You could assert that the value is in the past, but then you wouldn't be treating it as opaque. I plan to add list_snaphots in the near future, which might be the better way to improve this test?
Add support to
BlobClientfor taking snapshots of a blob. For now thisreuses the opaque type that already exists for
Snapshot, but it mightbe worth considering adding support for treating it as a
DateTime.