Improve storage operations #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Note:
Prior to this change, the operations that live in blob/operations could be summarized as "For a given blob, do these things" and the operations that live in container/operations could be summarized as "For a given container, do these things".
While find_blobs_by_tags is finds blobs, it operates on an account, not a blob.
|
@bmc-msft I moved the operation to the "service" module which seems to be the right place for it to live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
get_accountstorage operationfind_blobs_by_tagsa stream instead of futurefind_blobs_by_tagsinto theazure_blob_stroagesince it's blob specific and not general to all storage