move to using Cow<'static, str> for most headers/request options #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on comments from #951 |
rylev
reviewed
Jul 21, 2022
| pub const $variant: $name = $name::from_static($value); | ||
| )* | ||
|
|
||
| pub fn new<S>(s: S) -> Self |
There was a problem hiding this comment.
Seems like most of this stuff is shared. Can we share the definition? We can probably do all of this in one macro since the invocation is unambiguous between the two use cases.
There was a problem hiding this comment.
There needs to be some disambiguation because of either Header or AppendToUrlQuery implementation.
added 2 commits
July 21, 2022 13:52
rylev
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.